[Asterisk-code-review] func_groupcount.c: Adding Group Variables + additional Group functions (asterisk[18])

[N A]

Attention is currently required from: Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables + additional Group functions
......................................................................


Patch Set 25: Code-Review-1

(3 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/db0adb39_04c8d902 
PS25, Line 167: 			<example>Find groups containing 'foo': .*foo.*</example>
The description should go in the title attribute, and you should provide a full example

e.g.

<example title="Find groups containing foobar">${GROUP_CHANNEL_LIST(*bar)}</example>

For all 3.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b9274199_f406d76f 
PS25, Line 234: 			<example title="On Channel 1">
This description is not descriptive enough


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/95829079_e73853b5 
PS25, Line 238: 			<example title="On Channel 2">
Same with this one, and move the parenthetical inside the title



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 25
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Tue, 17 Jan 2023 21:50:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230117/30048b21/attachment.html>