[Asterisk-code-review] func_groupcount.c: Adding Group Variables + additional Group functions (asterisk[18])

[Mark Murawski]

Attention is currently required from: N A.

Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables + additional Group functions
......................................................................


Patch Set 20:

(6 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/0151cce6_113313d1 
PS20, Line 709: 	return -1;
> Is it appropriate to return -1 here? I think this will shut down the entire AMI connection
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/748a99b1_5936ed61 
PS20, Line 723: 	return -1;
> Same here, I think this needs to return 0
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b500ff23_27e75922 
PS20, Line 1181: 	buf[0] = '0'; buf[1] = 0;
> Either use a comma, or put these on separate lines.
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/388f3afa_db115842 
PS20, Line 1227: 		return 0;
> This is a function, so it is safe (and better) to return -1 on failure […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/3dabcc66_a1050454 
PS20, Line 1328: 		return 0;
> Should this return -1?
Done


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/08e4f44c_e05b9fdc 
PS20, Line 2488: {
> The * should go with the function name
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 20
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Sat, 14 Jan 2023 20:17:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230114/d9f3f5c4/attachment-0001.html>