[Asterisk-code-review] chan_dahdi: Add DAHDIBusyOut (asterisk[master])

N A asteriskteam at digium.com
Sun Jan 15 05:27:45 CST 2023


Attention is currently required from: Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19264 )

Change subject: chan_dahdi: Add DAHDIBusyOut
......................................................................


Patch Set 9:

(1 comment)

File channels/chan_dahdi.c:

https://gerrit.asterisk.org/c/asterisk/+/19264/comment/53ebd536_5c362624 
PS7, Line 20304: 
> > Again, I would ask the same question as before. […]
I think analog only is fine, too, and probably the most relevant use case.
I think this should actually be pretty simple, to queue a busy out, since you don't need to worry about automatically disabling it later, just automatically enabling it. So I think what I mentioned with setting that a flag and checking that when the line goes idle should work. Then, making sure you hold the pvt lock then, you can actually enable busy out at the time (simply by setting another flag to 1, for example, and doing anything else that might need to be done).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19264
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib75c87c554bb18b8f65be73b4474474e7e1877b7
Gerrit-Change-Number: 19264
Gerrit-PatchSet: 9
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Sun, 15 Jan 2023 11:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230115/d54255cd/attachment.html>


More information about the asterisk-code-review mailing list