[Asterisk-code-review] test.c: Avoid passing -1 to FD_* family of functions. (asterisk[18])

[George Joseph]

Attention is currently required from: Sean Bright.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19933 )

Change subject: test.c: Avoid passing -1 to FD_* family of functions.
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

File main/test.c:

https://gerrit.asterisk.org/c/asterisk/+/19933/comment/5d601bf1_81f6bd0d 
PS2, Line 476: #define SAFE_FD_ISSET(fd, setptr) ((fd) != -1 && FD_ISSET((fd), setptr))
> Usually when we do function specific defines, we do an undefine when we don't need it any more.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19933
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ib482847a3515364f14c7e7a0c0a4213851ddb10d
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 13:56:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230228/30821466/attachment-0001.html>