[Asterisk-code-review] test.c: Avoid passing -1 to FD_* family of functions. (asterisk[20])

Sean Bright asteriskteam at digium.com
Tue Feb 28 07:51:46 CST 2023


Attention is currently required from: Sean Bright.

Hello Joshua Colp, George Joseph, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/19943

to look at the new patch set (#2).

Change subject: test.c: Avoid passing -1 to FD_* family of functions.
......................................................................

test.c: Avoid passing -1 to FD_* family of functions.

This avoids buffer overflow errors when running tests that capture
output from child processes.

This also corrects a copypasta in an off-nominal error message.

Change-Id: Ib482847a3515364f14c7e7a0c0a4213851ddb10d
---
M main/test.c
1 file changed, 23 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/43/19943/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19943
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: Ib482847a3515364f14c7e7a0c0a4213851ddb10d
Gerrit-Change-Number: 19943
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230228/5a97dbee/attachment-0001.html>


More information about the asterisk-code-review mailing list