[Asterisk-code-review] app_queue: periodic announcement configurable start time. (asterisk[master])

N A asteriskteam at digium.com
Tue Feb 28 06:12:09 CST 2023


Attention is currently required from: Joshua Colp, Jaco Kroon.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19899 )

Change subject: app_queue: periodic announcement configurable start time.
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/b3f456be_73e26585 
PS3, Line 8: time interval than the frequency.
> > The commit message title is so long that it wraps to a another line. […]
Done


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/71fc8136_74de6c5e 
PS1, Line 283: ; may not always be desired.
> Rewrite completely, please do check if the latest attempt is better. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19899
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia79984b6377ef78f167ad9ea2ac084bec29955d0
Gerrit-Change-Number: 19899
Gerrit-PatchSet: 4
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Tue, 28 Feb 2023 12:12:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Jaco Kroon <jaco at uls.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230228/7ee60361/attachment-0001.html>


More information about the asterisk-code-review mailing list