[Asterisk-code-review] res_pjsip: Replace invalid UTF-8 sequences in callerid name (asterisk[18])
George Joseph
asteriskteam at digium.com
Fri Feb 24 17:03:04 CST 2023
Attention is currently required from: Sean Bright.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19898 )
Change subject: res_pjsip: Replace invalid UTF-8 sequences in callerid name
......................................................................
Patch Set 3: Code-Review-2
(1 comment)
Patchset:
PS2:
> > utf8.c:556:1: error: universal character names are only valid in C++ and C99
>
> I thought we compiled as C99?
I thought so as well but apparently not. gcc >= 5.x defaults to at least c99 but gcc <= 4.9 does not.
Anyway, I replaced all the universal character notations with hex byte sequences.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19898
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I4ffbdb19c80bf0efc675d40078a3ca4f85c567d8
Gerrit-Change-Number: 19898
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 23:03:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230224/6061dec1/attachment.html>
More information about the asterisk-code-review
mailing list