[Asterisk-code-review] app_queue: option to start the periodic announcements at a different... (asterisk[master])

[N A]

Attention is currently required from: Jaco Kroon.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19899 )

Change subject: app_queue:  option to start the periodic announcements at a different time interval than the frequency.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Patchset:

PS1: 
This also needs a CHANGES entry


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/3d696691_0537047b 
PS1, Line 3428: 		q->periodicannouncestartdelay = atoi(val);
This value should be initialized to 0 explicitly in init_queue


https://gerrit.asterisk.org/c/asterisk/+/19899/comment/3ce3ecb1_4bb673aa 
PS1, Line 8528: 	if (qe.parent->periodicannouncestartdelay >= 0) {
should this be > 0, not >= 0? Otherwise we're just adding 0 with the first statement.


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/a6b9ee26_755f4409 
PS1, Line 283: ; may not always be desired.
Is there a default value that should be specified here?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19899
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia79984b6377ef78f167ad9ea2ac084bec29955d0
Gerrit-Change-Number: 19899
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Friendly Automation
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Tue, 21 Feb 2023 12:31:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230221/ef0475f7/attachment-0001.html>