[Asterisk-code-review] app_senddtmf: Add option to answer target channel. (asterisk[18])

N A asteriskteam at digium.com
Tue Feb 21 06:29:09 CST 2023


Attention is currently required from: Michael Bradeen, Sean Bright.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19894 )

Change subject: app_senddtmf: Add option to answer target channel.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19894/comment/4be98c1e_9b31d1e6 
PS2, Line 11: current channel will be answered instead.
The current channel could be specified, but I'm not seeing the code that defaults to answering the current channel if no channel is specified? channel is mandatory so I'm not sure how the default works. Is the description accurate or is something missing?


Patchset:

PS1: 
> Okay, never mind, I see this is for the *destination* channel. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19894
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Iddcbd501fcdf9fef0f453b7a8115a90b11f1d085
Gerrit-Change-Number: 19894
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 12:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230221/588e67e2/attachment-0001.html>


More information about the asterisk-code-review mailing list