[Asterisk-code-review] app_read: Add an option to return terminator on empty digits. (asterisk[18])

N A asteriskteam at digium.com
Tue Feb 21 06:25:05 CST 2023


Attention is currently required from: Michael Bradeen, Sean Bright, Benjamin Keith Ford.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19883 )

Change subject: app_read: Add an option to return terminator on empty digits.
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/19883/comment/f34e311f_20c2e1f1 
PS2, Line 135: 	OPT_NOEMPTY = (1 << 4),
> How about OPT_KEEP_TERMINATOR or something along those lines?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19883
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I49f3221824330a193a20c660f99da0f1fc2cbbc5
Gerrit-Change-Number: 19883
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Benjamin Keith Ford <bford at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 12:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230221/1e2b6dfe/attachment.html>


More information about the asterisk-code-review mailing list