[Asterisk-code-review] app_queue: Add force_longest_waiting_caller option. (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Nathan Bruning.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19793 )

Change subject: app_queue: Add force_longest_waiting_caller option.
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/cd6df40f_10c96b16 
PS4, Line 7: app_queue: add option to connect agents only to longest waiting queue caller
> Also shorten this first line, capitalize 'Add' and make sure it ends in a period. […]
Done


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/9ced79ae_4c7e0439 
PS2, Line 9495: force_longest_waiting_caller 
> This seems like an odd place to set a default. […]
Done


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/47b66d7a_e5e5aa87 
PS3, Line 1610: static int force_longest_waiting_caller = 0;
> Strictly speaking, this initialization is unnecessary. […]
Done


File doc/CHANGES-staging/app_queue_force_longest_waiting_caller.txt:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/4400fdcb_43b4c408 
PS6, Line 1: Subject: app_queue
Sean's comment about the setting not applying per queue would apply to this as well



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19793
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4a8e4c21c60639c214114fc909226c175a8849f9
Gerrit-Change-Number: 19793
Gerrit-PatchSet: 6
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Nathan Bruning <nathan at iperity.com>
Gerrit-Comment-Date: Fri, 17 Feb 2023 13:09:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230217/b2130b40/attachment-0001.html>