[Asterisk-code-review] pbx_dundi: Add PJSIP support. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19702 )

Change subject: pbx_dundi: Add PJSIP support.
......................................................................


Patch Set 5:

(1 comment)

File configs/samples/dundi.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19702/comment/ccc7ef5e_2f514b42 
PS5, Line 81: ; Default is to use the channel technology indicated by the DUNDi peer, but
> I don't think the DUNDi peer should specify at all. […]
Since SIP is on its way out now anyways, already or in all branches where this is relevant, I presume it'd be fine to make PJSIP the default then? Just so we have a sane default even if it's not explicitly set.

The problem is PJSIP requires an endpoint to be specified explicitly, so I can't really see how this would ever be plug and play. So for that reason, maybe there shouldn't be a default, since manual configuration is always required for PJSIP.

Any thoughts?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19702
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2e28e5a5d007bd49e3df113ad567b011103899bf
Gerrit-Change-Number: 19702
Gerrit-PatchSet: 5
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 13 Feb 2023 12:34:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230213/30510803/attachment-0001.html>