[Asterisk-code-review] media cache: make sure generated filenames cannot conflict (asterisk[master])

Nathan Bruning asteriskteam at digium.com
Wed Feb 8 05:57:40 CST 2023


Attention is currently required from: Sean Bright.

Hello Sean Bright, N A, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/19797

to look at the new patch set (#2).

Change subject: media cache: make sure generated filenames cannot conflict
......................................................................

media cache: make sure generated filenames cannot conflict

In rare cases, two entries of the media cache would have the same
base file name, only with different extensions. During media lookup,
the wrong file can be played, depending on the channel format.

This patch avoids the 'lookup file by extension' for files that
originate from the media cache.

ASTERISK-30408 #close

Change-Id: If6b5f4af9cbdf39009252594eb987b07bfb493a4
---
M main/file.c
1 file changed, 129 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/97/19797/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19797
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6b5f4af9cbdf39009252594eb987b07bfb493a4
Gerrit-Change-Number: 19797
Gerrit-PatchSet: 2
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230208/9984ffd8/attachment-0001.html>


More information about the asterisk-code-review mailing list