[Asterisk-code-review] res_http_media_cache: Introduce options and customize (asterisk[20])

N A asteriskteam at digium.com
Sat Feb 4 06:37:30 CST 2023


Attention is currently required from: Sean Bright, Holger Hans Peter Freyther, George Joseph.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Introduce options and customize
......................................................................


Patch Set 7:

(1 comment)

File configs/samples/res_http_media_cache.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/2f6846dc_17218d52 
PS7, Line 12: [general]
> Happy to do that but then we have to maintain this in the sample _and_ the module docs. […]
I wouldn't say it's the "goal", but that is what most modules do.
Some people may only look at the sample config and never look at the documentation.
As well, every sample config has the options documented typically, but not all modules (most older modules, for instance) have XML documentation for the configs.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 7
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Sat, 04 Feb 2023 12:37:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230204/6f5da165/attachment.html>


More information about the asterisk-code-review mailing list