[Asterisk-code-review] app_queue: Minor docs and logging fixes for UnpauseQueueMember. (asterisk[18])

N A asteriskteam at digium.com
Thu Feb 2 08:49:48 CST 2023


Attention is currently required from: Sean Bright.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19889 )

Change subject: app_queue: Minor docs and logging fixes for UnpauseQueueMember.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19889/comment/8f018a17_239ef6fe 
PS2, Line 8196: 		ast_log(LOG_WARNING, "Missing interface argument to UnpauseQueueMember ([queuename],interface[,options[,reason]])\n");
I know this isn't very consistent with applications (although functions do this), but maybe replace this with %s and pass in app_upqm as an argument, to avoid duplicating app names when we don't have to?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19889
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I7534e7a925bf92a7b5a5347f5f54225768c162fe
Gerrit-Change-Number: 19889
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Thu, 02 Feb 2023 14:49:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230202/5c7e4e41/attachment.html>


More information about the asterisk-code-review mailing list