[Asterisk-code-review] media cache: make sure generated filenames cannot conflict (asterisk[master])

Sean Bright asteriskteam at digium.com
Wed Feb 1 10:00:59 CST 2023


Attention is currently required from: Nathan Bruning.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19797 )

Change subject: media cache: make sure generated filenames cannot conflict
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> Hi Sean, […]
Ultimately the check-then-act is always going to result in a race condition. We store the extension in the cache metadata, I wonder if we could find a way to avoid adding an extension altogether?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19797
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6b5f4af9cbdf39009252594eb987b07bfb493a4
Gerrit-Change-Number: 19797
Gerrit-PatchSet: 1
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Nathan Bruning <nathan at iperity.com>
Gerrit-Comment-Date: Wed, 01 Feb 2023 16:00:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Nathan Bruning <nathan at iperity.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230201/3159dd30/attachment-0001.html>


More information about the asterisk-code-review mailing list