[Asterisk-code-review] res_pjsip: mediasec: Add Security-Client headers after 401 (asterisk[18])

Maximilian Fridrich asteriskteam at digium.com
Wed Apr 19 07:33:38 CDT 2023


Attention is currently required from: Joshua Colp, Stanislav Abramenkov.

Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19740 )

Change subject: res_pjsip: mediasec: Add Security-Client headers after 401
......................................................................


Patch Set 3:

(2 comments)

Patchset:

PS2: 
> I think that we need to make a small change in module description: […]
Done.


File res/res_pjsip_rfc3329.c:

https://gerrit.asterisk.org/c/asterisk/+/19740/comment/2ca08830_0a911cbf 
PS2, Line 37: static pjsip_module rfc3329_module = {
> Good to know! I should probably be using a datastore and add it to the session supplement. […]
I have updated the patch, it is using an ast_datastore now.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19740
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ief7857365f221b1ef28672a27cc3fb27384c8d0f
Gerrit-Change-Number: 19740
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-CC: Friendly Automation
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 12:33:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Comment-In-Reply-To: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230419/0575d2d8/attachment.html>


More information about the asterisk-code-review mailing list