[Asterisk-code-review] res_prometheus: Do not generate broken metrics (asterisk[20])

Holger Hans Peter Freyther asteriskteam at digium.com
Fri Apr 7 05:30:32 CDT 2023


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/20037

to look at the new patch set (#2).

Change subject: res_prometheus: Do not generate broken metrics
......................................................................

res_prometheus: Do not generate broken metrics

In I58ef9f44036feded5966b5fc70ae754f8182883d invisible bridges were
skipped but that lead to producing metrics with no name and no help.

Keep track of the number of metrics configured and then only emit these.
Add a basic testcase that verifies that there is no '(NULL)' in the
output.

ASTERISK-30474

Change-Id: I06798d6085e3b36fdc63ab8554912f2b5bcc480b
---
M res/prometheus/bridges.c
M tests/test_res_prometheus.c
2 files changed, 74 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/37/20037/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20037
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I06798d6085e3b36fdc63ab8554912f2b5bcc480b
Gerrit-Change-Number: 20037
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230407/7f3b9294/attachment.html>


More information about the asterisk-code-review mailing list