[Asterisk-code-review] app_queue: Fix minor xmldoc duplication and vagueness. (asterisk[master])

Sean Bright asteriskteam at digium.com
Mon Apr 3 11:07:22 CDT 2023


Attention is currently required from: N A.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20032 )

Change subject: app_queue: Fix minor xmldoc duplication and vagueness.
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS2: 
Not going to -1 over something so trivial, but it could still use some improvement.


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/20032/comment/d586331c_ac4ce893 
PS2, Line 164: If this option is enabled, DTMF will not
             : 						be verified.
Can't we just say "This option disables that behavior" rather than restating something the reader has just read? This just feels verbose for the sake of it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20032
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6706cea708b5cc781f59f8652c2cb377e55aed7e
Gerrit-Change-Number: 20032
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Mon, 03 Apr 2023 16:07:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230403/6aa0b5f9/attachment.html>


More information about the asterisk-code-review mailing list