[Asterisk-code-review] app_queue: Fix minor xmldoc duplication and vagueness. (asterisk[master])

Sean Bright asteriskteam at digium.com
Mon Apr 3 10:28:35 CDT 2023


Attention is currently required from: N A.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20032 )

Change subject: app_queue: Fix minor xmldoc duplication and vagueness.
......................................................................


Patch Set 1:

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/20032/comment/aa32f127_65cd26c3 
PS1, Line 162: 					<para>This option only applies to DAHDI channels. If enabled,
             : 						DTMF will not be verified by muting audio TX/RX to verify
             : 						the tone is still present.</para>
> I mean not. By default, DTMF is verified for DAHDI channels. The d option disables this.
The mixture of positives and negatives makes that unclear. To make it more accessible it would be better to describe the default behavior and then separately indicate that the default behavior is being disabled by this flag.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20032
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6706cea708b5cc781f59f8652c2cb377e55aed7e
Gerrit-Change-Number: 20032
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Mon, 03 Apr 2023 15:28:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230403/52889b96/attachment.html>


More information about the asterisk-code-review mailing list