[Asterisk-code-review] chan_pjsip: fix music on hold continues after INVITE with replaces (asterisk[18])

[Sean Bright]

Attention is currently required from: N A, Henning Westerholt.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20020 )

Change subject: chan_pjsip: fix music on hold continues after INVITE with replaces
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/20020/comment/fbac41e7_da9f8e73 
PS1, Line 10: continue 
> continues
👍


File res/res_pjsip_refer.c:

https://gerrit.asterisk.org/c/asterisk/+/20020/comment/cf882679_377d43cf 
PS1, Line 1022: 	/* Unhold the channel already, as later we are not having access to it anymore */
> How about rephrasing as "Unhold the channel now, as later we don't have access to it anymore". […]
👍



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20020
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I5675df11e739be5226b328f8828d4b8d81fbefb4
Gerrit-Change-Number: 20020
Gerrit-PatchSet: 3
Gerrit-Owner: Henning Westerholt <hw at gilawa.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Henning Westerholt <hw at gilawa.com>
Gerrit-Comment-Date: Mon, 03 Apr 2023 14:33:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230403/04a3e3d3/attachment.html>