[Asterisk-code-review] test.c: Fix counting of tests and add 2 new tests (asterisk[18])

George Joseph asteriskteam at digium.com
Mon Apr 3 08:40:34 CDT 2023


Attention is currently required from: Sean Bright.

Hello Sean Bright, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/20030

to look at the new patch set (#3).

Change subject: test.c: Fix counting of tests and add 2 new tests
......................................................................

test.c: Fix counting of tests and add 2 new tests

The unit test XML output was counting all registered tests as "run"
even when only a subset were actually requested to be run and
the "failures" attribute was missing.

* The "tests" attribute of the "testsuite" element in the
  output XML now reflects only the tests actually requested
  to be executed instead of all the tests registered.

* The "failures" attribute was added to the "testsuite"
  element.

Also added 2 new unit tests that just pass and fail to be
used for CI testing.

Change-Id: Ia137814b5aeb0e1a44c75034bd3615c26021da69
---
A doc/CHANGES-staging/test.txt
M main/test.c
M tests/test_pbx.c
3 files changed, 79 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/30/20030/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20030
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia137814b5aeb0e1a44c75034bd3615c26021da69
Gerrit-Change-Number: 20030
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230403/e42fdbd2/attachment.html>


More information about the asterisk-code-review mailing list