[Asterisk-code-review] test.c: Fix counting of tests and add 2 new tests (asterisk[18])

Sean Bright asteriskteam at digium.com
Mon Apr 3 08:34:40 CDT 2023


Attention is currently required from: George Joseph.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20030 )

Change subject: test.c: Fix counting of tests and add 2 new tests
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS2: 
I apologize.


File tests/test_pbx.c:

https://gerrit.asterisk.org/c/asterisk/+/20030/comment/0636f184_16925cf6 
PS2, Line 430: AST_TEST_UNREGISTER(just_fail);
             : 	AST_TEST_UNREGISTER(just_pass);
The other tests are unregistered in the opposite order that they are registered. I think these new tests should follow that pattern.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20030
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia137814b5aeb0e1a44c75034bd3615c26021da69
Gerrit-Change-Number: 20030
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 03 Apr 2023 13:34:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230403/30068b4a/attachment.html>


More information about the asterisk-code-review mailing list