[Asterisk-code-review] media cache: make sure generated filenames cannot conflict (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Nathan Bruning.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19797 )

Change subject: media cache: make sure generated filenames cannot conflict
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

Patchset:

PS1: 
> Hi Sean, […]
Have you tried generating a video file yourself using Record() or one of the video-supporting applications? It's been a while since I've done that, but I seem to recall that you can generate your own compatible h264 files that way.


File main/file.c:

https://gerrit.asterisk.org/c/asterisk/+/19797/comment/9c72fd32_8330ae03 
PS3, Line 546: 	if ( (bfile = fopen(fn, "r")) == NULL) {
Remove the extra space between the parentheses


https://gerrit.asterisk.org/c/asterisk/+/19797/comment/3fccd721_c4ed2e5e 
PS3, Line 564: 		if (ast_channel_stream(chan))
The "optional" braces are always required per the coding guidelines: https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines#CodingGuidelines-Nonestedstatementswithoutbraces


https://gerrit.asterisk.org/c/asterisk/+/19797/comment/aa80bb00_34210372 
PS3, Line 568: 		if (ast_channel_vstream(chan))
Same here


https://gerrit.asterisk.org/c/asterisk/+/19797/comment/80873168_e49ffc98 
PS3, Line 587: 	{
Move the opening brace to the previous line, just like a for loop.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19797
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6b5f4af9cbdf39009252594eb987b07bfb493a4
Gerrit-Change-Number: 19797
Gerrit-PatchSet: 3
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Nathan Bruning <nathan at iperity.com>
Gerrit-Comment-Date: Sat, 01 Apr 2023 22:46:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Nathan Bruning <nathan at iperity.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230401/eeff2457/attachment-0001.html>