[Asterisk-code-review] app_queue: Preserve reason for realtime queues. (asterisk[18])

[N A]

Attention is currently required from: Sean Bright, Alexei Gradinari, Stanislav Abramenkov, Niklas Larsson.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19741 )

Change subject: app_queue: Preserve reason for realtime queues.
......................................................................


Patch Set 14: Code-Review-1

(3 comments)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/8c6a4aa4_011abd2a 
PS14, Line 1628: static int realtime_reason_paused = 0;
Currently, this is only set to 1 when the module loads. Is it possible that the backend could not support it when the module loads but not at some later point, or vice versa? (Asking since I don't know much about realtime). If so, maybe you'd want to initialize in queue_reset_global_params and queue_set_global_params.


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/b9840554_ef76d6d0 
PS14, Line 11740: 		realtime_reason_paused = 0;
This is initialized twice, which isn't necessary.
As written you'd want to keep the global assignment since if there's a member_config but reason_paused isn't set, it wouldn't be uninitialized otherwise.

Assuming you leave things as is, this assignment could be safely removed.


File doc/CHANGES-staging/app_queue_realtime_reason_paused.txt:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/4d1aca73_1467a618 
PS14, Line 3:  
The line wrapping splits this word across two lines, wrap this earlier.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19741
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ica08baa5cab6b18105b5d719a183f9fd582fcf09
Gerrit-Change-Number: 19741
Gerrit-PatchSet: 14
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Niklas Larsson <niklas at tese.se>
Gerrit-Comment-Date: Sat, 01 Apr 2023 22:42:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230401/7d76ba77/attachment.html>