[Asterisk-code-review] audiohook: add directional awareness (asterisk[18])

[Michael Bradeen]

Attention is currently required from: N A, Joshua Colp.

Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19318 )

Change subject: audiohook: add directional awareness
......................................................................


Patch Set 2:

(2 comments)

File main/audiohook.c:

https://gerrit.asterisk.org/c/asterisk/+/19318/comment/e74e66d5_44cfa5d9 
PS1, Line 168: 	if(audiohook->direction!= AST_AUDIOHOOK_DIRECTION_BOTH && audiohook->direction!=direction){
> Add spaces around the !='s and before the opening brace, and after the if(
Done


File res/res_stasis_snoop.c:

https://gerrit.asterisk.org/c/asterisk/+/19318/comment/103e2db0_8e3790f0 
PS1, Line 291: 	audiohook->direction = *direction;
> Audiohook should be treated as opaque, and an API call added. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19318
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: If8716bad334562a5d812be4eeb2a92e4f3be28eb
Gerrit-Change-Number: 19318
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 18:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220930/c5a48106/attachment.html>