[Asterisk-code-review] res_pjsip_outbound_registration: Allow to use multiple proxies for re... (asterisk[16])

[Igor Goncharovsky]

Attention is currently required from: Joshua Colp.

Igor Goncharovsky has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19202 )

Change subject: res_pjsip_outbound_registration: Allow to use multiple proxies for registration
......................................................................


Patch Set 2:

(2 comments)

File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/19202/comment/b035b59e_f6c7cd1a 
PS1, Line 1407: 	if (!ast_strlen_zero(registration->outbound_proxy)) {
> This doesn't need to done at all
Ack


https://gerrit.asterisk.org/c/asterisk/+/19202/comment/1fc9c24c_ab44be8c 
PS1, Line 1409: 		uri = pjsip_parse_uri(pool, tmp.ptr, tmp.slen, 0);
> Ok, then my other comment about duplicating the outbound proxy no longer being needed still applies.
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19202
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I064558e66f04b9f3260c46181812a01349761357
Gerrit-Change-Number: 19202
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 16:56:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220928/41eac9e0/attachment-0001.html>