[Asterisk-code-review] res_pjsip: return all codecs on a re-INVITE without SDP (asterisk[16])

[Henning Westerholt]

Attention is currently required from: Joshua Colp, N A.

Henning Westerholt has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18990 )

Change subject: res_pjsip: return all codecs on a re-INVITE without SDP
......................................................................


Patch Set 6:

(4 comments)

Patchset:

PS6: 
Thanks, should be done now. Alembic and CHANGES were done as well.


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/766a4101_d601729a 
PS3, Line 1281:                     ; Return all codecs on empty re-INVITE.
> This needs to be more thoroughly documented about what it actually does. For example: […]
Done


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/a34bada3_e08195f0 
PS3, Line 2077: 						Return all codecs on empty re-INVITE. RFC 3261
> Comment I provided per sample config also applies here
Done


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/490bbcc1_29da230a 
PS3, Line 5067: 		if (session->active_media_state->topology && !answer_all_codecs) {
> If there are multiple streams, what is the consequence of not using the active media state topology? […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18990
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148
Gerrit-Change-Number: 18990
Gerrit-PatchSet: 6
Gerrit-Owner: Henning Westerholt <hw at gilawa.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 09:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220928/a915159d/attachment-0001.html>