[Asterisk-code-review] app_broadcast: Add Broadcast application (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18975 )

Change subject: app_broadcast: Add Broadcast application
......................................................................


Patch Set 3:

(7 comments)

File apps/app_broadcast.c:

https://gerrit.asterisk.org/c/asterisk/+/18975/comment/9b378c59_3082a46b 
PS2, Line 363: 		if ((mac = ast_calloc(1, sizeof(*mac)))) {
> Reduce indentation, if this fails then just unref and continue
Done


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/71c320dc_5c29263e 
PS2, Line 366: 			if (!mac->name || !mac->autochan) {
> Same here, reduce indentation
Done


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/07fa62a1_516c9222 
PS2, Line 414: 	while (numchans && ast_waitfor(chan, 1000) > 0) {
> Wait for 1 second for frames on the channel - this seems to be pretty common in the codebase. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/91b8b2d1_f671d5a7 
PS2, Line 525: 
> This should store the old format, and then return the channel to it after do_broadcast.
Done


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/713d6657_475e7e48 
PS2, Line 538: 	int res = 0;
> There is no need for res here
Done


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/3e233ca0_7de44f2b 
PS2, Line 547: 	int res = 0;
> Same here
Done


File apps/app_multicast.c:

https://gerrit.asterisk.org/c/asterisk/+/18975/comment/9044e3ef_81287b87 
PS1, Line 19:  * \brief Channel audio multicasting
> Similar to, but is not using multicast underneath. Broadcast is better.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18975
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7ba72f765dbab9b58deeae028baca3f4f8377726
Gerrit-Change-Number: 18975
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 12:25:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220927/36cd322a/attachment.html>