[Asterisk-code-review] app_broadcast: Add Broadcast application (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18975 )

Change subject: app_broadcast: Add Broadcast application
......................................................................


Patch Set 2:

(1 comment)

File apps/app_broadcast.c:

https://gerrit.asterisk.org/c/asterisk/+/18975/comment/787b1f8c_b9d61421 
PS2, Line 414: 	while (numchans && ast_waitfor(chan, 1000) > 0) {
> Wait for 1 second for frames on the channel - this seems to be pretty common in the codebase. […]
I understand what it does, but I was trying to understand why you were doing it beyond because other things are doing it. It means that if no frames come from the channel in 1 second, then it'll be hung up. Is this what you want to happen? Should it be -1 instead and strictly waiting on frames for the channel?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18975
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7ba72f765dbab9b58deeae028baca3f4f8377726
Gerrit-Change-Number: 18975
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 12:00:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220927/6cd3fe2e/attachment.html>