[Asterisk-code-review] app_broadcast: Add Broadcast application (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18975 )

Change subject: app_broadcast: Add Broadcast application
......................................................................


Patch Set 2: Code-Review-1

(6 comments)

File apps/app_broadcast.c:

https://gerrit.asterisk.org/c/asterisk/+/18975/comment/3dff03fd_3a10777e 
PS2, Line 363: 		if ((mac = ast_calloc(1, sizeof(*mac)))) {
Reduce indentation, if this fails then just unref and continue


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/2a3ddbcf_08943035 
PS2, Line 366: 			if (!mac->name || !mac->autochan) {
Same here, reduce indentation


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/3e0c83c1_1d8fb409 
PS2, Line 414: 	while (numchans && ast_waitfor(chan, 1000) > 0) {
Where does the 1000 come from?


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/f9bae43a_d19d5d1a 
PS2, Line 525: 
This should store the old format, and then return the channel to it after do_broadcast.


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/f5b3a6ec_d5e82650 
PS2, Line 538: 	int res = 0;
There is no need for res here


https://gerrit.asterisk.org/c/asterisk/+/18975/comment/22d9adbc_89d1ab91 
PS2, Line 547: 	int res = 0;
Same here



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18975
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7ba72f765dbab9b58deeae028baca3f4f8377726
Gerrit-Change-Number: 18975
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 11:29:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220927/65d22b82/attachment.html>