[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[N A]

Attention is currently required from: Sean Bright, Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 19: Code-Review-1

(10 comments)

Patchset:

PS19: 
Real close... a few more things


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/285679f8_b84b0134 
PS11, Line 1385: 			ast_str_append(&out, 0, "%s,", ast_channel_name(gi->chan));
> Additionally, given the snafu that has already happened here, I think a simple test for GROUP_CHANNE […]
Ack


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/3168d831_1265190f 
PS19, Line 1041: 
I think ast_str_create can fail... you should check for failure everywhere you call this.


File include/asterisk/channel.h:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/bd7afa0e_13d16dc8 
PS14, Line 2931: 	struct varshead varshead;			/*!< A linked list for group variables. See \ref AstGroupVar */
> I don't think I see an issue here.   The comments are already lined up with tabs.
Ack


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/52debfcf_426be274 
PS19, Line 2423: int ast_app_group_set_var(struct ast_channel *chan, const char *group, const char *category, const char *name, const char *value) {
Opening brace should be on a separate line (K&R)


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/ce0a8ab3_9005fd92 
PS19, Line 2487: const char* ast_app_group_get_var(const char *group, const char *category, const char *name) {
Opening brace should be on a separate line (K&R)


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/532753db_1a40008e 
PS19, Line 2668: int ast_app_group_add_channel(struct ast_channel *chan, char *group, char *category) {
Opening brace should be on a separate line (K&R)


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/9b8a8392_3861bf35 
PS19, Line 2716: int ast_app_group_remove_all_channels(const char *group, const char *category) {
Opening brace should be on a separate line (K&R)


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/0fbb96a4_ecc0774a 
PS19, Line 2745: int ast_app_group_rename(const char *old_group, const char *old_category, const char *new_group, const char *new_category) {
Opening brace should be on a separate line (K&R)


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b5deb797_a37c20bc 
PS19, Line 1909: int group_show_channels_callback(void *obj, void *arg, int flags);
Why do we need this forward declaration?
This should either be in the header file or static?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 19
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Mon, 26 Sep 2022 21:53:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220926/cfa2ce8e/attachment-0001.html>