[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[N A]

Attention is currently required from: Sean Bright, Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 15: Code-Review-1

(19 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/efb26348_9c503f29 
PS14, Line 795: 
> I don't follow this one... […]
I don't mean what you did above aligning the variable definitions, I mean proper indentation in general.


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/1612d994_277c70b7 
PS15, Line 792: 		if (group_or_regex[0] == '/') {
For example, this should be indented one level from the line above.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/1a714028_7bf77d81 
PS15, Line 813: 		else {
The else should go on the same line as the closing brace above.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/0e5fbab7_f3e188d8 
PS15, Line 818:         if (!ast_strlen_zero(category_or_regex)) {
Same here


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/045b1194_4627ec1c 
PS15, Line 842: 		else {
Same here


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/368a5b95_403d1688 
PS15, Line 890:         if (group_regex_string) {
Unindent


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/dc526a63_cb6d6762 
PS15, Line 895:         if (category_regex_string) {
This should be unindented one level


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/d82c2f76_edbc5211 
PS15, Line 908: 
Here is another indentation messup: these 2 lines should be unindented one level. Also they are using spaces, not tabs, that needs to be fixed.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/f63a2b2f_cb5a3de4 
PS15, Line 922:         if (!ast_strlen_zero(group_or_regex)) {
ditto


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/65012d49_4a84809d 
PS15, Line 944: 		else {
ditto


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/a10cdc10_2b58677c 
PS15, Line 949:         if (!ast_strlen_zero(category_or_regex)) {
ditto


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/735936ee_08004754 
PS15, Line 973: 		else {
ditto


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/83dca81f_b2b9ea53 
PS15, Line 1022:         if (group_regex_string) {
ditto


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/97dff981_67e8df0f 
PS15, Line 1027:         if (category_regex_string) {
ditto


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/e0f2c158_879dca29 
PS15, Line 1168: 	else {
ditto


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/3d633ce1_c7e610b2 
PS15, Line 1394: 		strncpy(buf, ast_str_buffer(out), len);
Could we use ast_copy_string instead of strncpy?


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/5dd59365_b2c4f720 
PS15, Line 2490:     
spaces/tabs and alignment


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/4ee9eb8f_9fa88d83 
PS15, Line 2501: 
You are using spaces here, not tabs


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/ed87b101_503ac947 
PS15, Line 2618: 
WHOLE function: spaces/tabs and alginment
I'm going to stop reviewing here, fix the rest of this file



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 15
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Mon, 26 Sep 2022 16:50:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220926/aa9c056d/attachment.html>