[Asterisk-code-review] func_scramble: Fix null pointer dereference. (asterisk[master])

Friendly Automation asteriskteam at digium.com
Thu Sep 22 10:23:29 CDT 2022


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/19203 )

Change subject: func_scramble: Fix null pointer dereference.
......................................................................

func_scramble: Fix null pointer dereference.

Fix segfault due to null pointer dereference
inside the audiohook callback.

ASTERISK-30220 #close

Change-Id: Ideb80f606974366e89d619d908744230b5a5a259
---
M funcs/func_scramble.c
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit




diff --git a/funcs/func_scramble.c b/funcs/func_scramble.c
index 5fe194c..e055b2d 100644
--- a/funcs/func_scramble.c
+++ b/funcs/func_scramble.c
@@ -125,6 +125,7 @@
 	}
 
 	if (frame->frametype == AST_FRAME_VOICE) { /* only invert voice frequencies */
+		ni = datastore->data;
 		/* Based on direction of frame, and confirm it is applicable */
 		if (!(direction == AST_AUDIOHOOK_DIRECTION_READ ? ni->rx : ni->tx)) {
 			return 0;

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19203
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ideb80f606974366e89d619d908744230b5a5a259
Gerrit-Change-Number: 19203
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220922/a5a4d6e8/attachment-0001.html>


More information about the asterisk-code-review mailing list