[Asterisk-code-review] res_pjsip_geolocation: Change some notices to debugs. (asterisk[master])

N A asteriskteam at digium.com
Mon Sep 19 13:07:37 CDT 2022


N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19305 )

Change subject: res_pjsip_geolocation: Change some notices to debugs.
......................................................................


Patch Set 1:

(1 comment)

File res/res_pjsip_geolocation.c:

https://gerrit.asterisk.org/c/asterisk/+/19305/comment/c3c3de2c_d9e5bf39 
PS1, Line 194: 			SCOPE_EXIT_LOG_RTN_VALUE(0, LOG_DEBUG, "%s: Endpoint has no geoloc_incoming_call_profile. "
Something odd here is if that if you use 1 instead 0, things behave as if an ast_channel_unref was forgotten somewhere.... actually what happens is the debug is executed but nothing ever happens on the channel afterwards and it gets "stuck" there.

0 works fine, but then the debug ALWAYS gets outputted even if core debug level is 0, and I don't think that is appropriate either.

What I'm trying to do is the debug level with at least sub level 1.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19305
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I656b355d812f67cc0f0fdf09b00b0e1458598bb4
Gerrit-Change-Number: 19305
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Mon, 19 Sep 2022 18:07:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220919/9e40620e/attachment.html>


More information about the asterisk-code-review mailing list