[Asterisk-code-review] app_amd: Add option to play audio during AMD. (asterisk[master])

N A asteriskteam at digium.com
Mon Sep 19 10:38:08 CDT 2022


Attention is currently required from: Joshua Colp, George Joseph.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18974 )

Change subject: app_amd: Add option to play audio during AMD.
......................................................................


Patch Set 7:

(1 comment)

File apps/app_amd.c:

https://gerrit.asterisk.org/c/asterisk/+/18974/comment/eb99723b_a24d051c 
PS6, Line 305: 		ast_stopstream(chan);
> Why are you doing a stopstream here?
The idea was to stop any currently playing audio, but I guess it's not necessary.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18974
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4af306274552b61b3d9f0883c33f698abd4699b6
Gerrit-Change-Number: 18974
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 19 Sep 2022 15:38:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220919/e6c29419/attachment.html>


More information about the asterisk-code-review mailing list