[Asterisk-code-review] res_pjsip: Add mediasec capabilities. (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Maximilian Fridrich.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18837 )

Change subject: res_pjsip: Add mediasec capabilities.
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

Patchset:

PS9: 
Minor comment.


File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/75219442_bd98cfd7 
PS9, Line 647: 		&& reg->endpoint && (endpt = ast_sorcery_retrieve_by_id(ast_sip_get_sorcery(), "endpoint", reg->endpoint))
For checking the presence of a string it is safer to use !ast_strlen_zero



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18837
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia7f5b5ba42db18074fdd5428c4e1838728586be2
Gerrit-Change-Number: 18837
Gerrit-PatchSet: 9
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Mon, 19 Sep 2022 11:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220919/ec923c80/attachment-0001.html>