[Asterisk-code-review] chan_dahdi: Add DAHDIBusyOut (asterisk[master])

[Mark Murawski]

Attention is currently required from: N A.

Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19264 )

Change subject: chan_dahdi: Add DAHDIBusyOut
......................................................................


Patch Set 3:

(8 comments)

Patchset:

PS2: 
> As a general comment, your spacing is all off. […]
Done


File channels/chan_dahdi.h:

https://gerrit.asterisk.org/c/asterisk/+/19264/comment/a6972b1a_0d8fcf41 
PS1, Line 211:        unsigned int _busydetect:1;
> I think this variable should be renamed, and the description updated appropriately. […]
Done


File channels/chan_dahdi.c:

https://gerrit.asterisk.org/c/asterisk/+/19264/comment/9eb2d9cf_a28de522 
PS2, Line 8682:                return &p->subs[idx].f;;
> Duplicate semicolon
Done


https://gerrit.asterisk.org/c/asterisk/+/19264/comment/f0f56235_669fba66 
PS2, Line 9788:                res = pbx_exec(chan, theapp, NULL);
> Two things: […]
The reason for the answer is to fully 'open the line' in terms of what dahdi is concerned with.  I don't recall specifically, but I vaguely remember running into issues keeping the channel open if it wasn't Answer()'d.


https://gerrit.asterisk.org/c/asterisk/+/19264/comment/9441226e_a949a68a 
PS2, Line 9791:                        ast_log(LOG_WARNING, "PBX exited non-zero\n");
> Yeah, and we don't need this either, just call the right ast_ API directly.
Done


https://gerrit.asterisk.org/c/asterisk/+/19264/comment/297c540a_892c1104 
PS2, Line 11976: 
> remove
Done


https://gerrit.asterisk.org/c/asterisk/+/19264/comment/08dade32_96687c4d 
PS2, Line 20378: //     ast_log(LOG_NOTICE, "channels: %s\n", channel_arg);
> Remove these commented out logs
Done


https://gerrit.asterisk.org/c/asterisk/+/19264/comment/849e93a6_bbf22a0c 
PS2, Line 20540:                ast_log(LOG_WARNING, "Channel DAHDI/%d busyout queue cancelled\n", dahdi_chan->channel);
> why is this a warning?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19264
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib75c87c554bb18b8f65be73b4474474e7e1877b7
Gerrit-Change-Number: 19264
Gerrit-PatchSet: 3
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 13:41:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220916/87a82e75/attachment.html>