[Asterisk-code-review] core & res_pjsip: Improve topology change handling. (asterisk[16])

[Maximilian Fridrich]

Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19059 )

Change subject: core & res_pjsip: Improve topology change handling.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
As expected, test_resolve_refresh_media_states failed as I changed the logic of resolve_refresh_media_states.

I am wondering what the reasoning was to stop processing the refresh if the current active state differs from the pending active state. As I have stated in the commit message, I think the careful queuing and re-queuing of requests (mostly in sip_session_refresh()) should ensure that refreshs are sent in the order they are received.

What the current logic results in is that if one of the queued refreshes changes the (current active) topology, then any other refresh in the queue is dropped because then delayed active differs from current active. I'm not sure if that is the desired behavior.

To verify this PR I would have to change the resolve_refresh_media_state test as well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19059
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Icd0703295271089057717006730b555b9a1d4e5a
Gerrit-Change-Number: 19059
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Thu, 08 Sep 2022 06:59:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220908/b93e7b48/attachment.html>