[Asterisk-code-review] runInVenv: Remove output redirection. (testsuite[16])

Friendly Automation asteriskteam at digium.com
Wed Sep 7 12:28:29 CDT 2022


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/testsuite/+/19080 )

Change subject: runInVenv: Remove output redirection.
......................................................................

runInVenv: Remove output redirection.

runInVenv.sh calls setupVenv.sh and redirects all
output to /dev/null, which means if an error occurs
we will never know about it. This removes stderr
redirection so the user will know what went wrong.

ASTERISK-30206 #close

Change-Id: I79b32c5374d142688ef4fa26990628aa9c3fcf36
---
M runInVenv.sh
1 file changed, 17 insertions(+), 1 deletion(-)

Approvals:
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit




diff --git a/runInVenv.sh b/runInVenv.sh
index 0a47151..8b280b2 100755
--- a/runInVenv.sh
+++ b/runInVenv.sh
@@ -16,7 +16,7 @@
 if [ $REINSTALL -eq 1 ] ; then
     echo "Reinstall required, removing and recreating venv"
 	rm -rf .venv
-    ./setupVenv.sh > /dev/null 2>&1
+    ./setupVenv.sh > /dev/null
 
 fi
 

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/19080
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I79b32c5374d142688ef4fa26990628aa9c3fcf36
Gerrit-Change-Number: 19080
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220907/91ab9222/attachment.html>


More information about the asterisk-code-review mailing list