[Asterisk-code-review] res_pjsip: Add TEL URI support for basic calls. (asterisk[16])

[Joshua Colp]

Attention is currently required from: Michael Bradeen, N A, Alexei Gradinari, George Joseph, Benjamin Keith Ford.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18892 )

Change subject: res_pjsip: Add TEL URI support for basic calls.
......................................................................


Patch Set 4:

(3 comments)

File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/18892/comment/d6f97e51_138a6bb4 
PS4, Line 3501: User string or empty string if not present
> It could go either way. […]
From a usability perspective I prefer returning an empty string.


File res/res_pjsip_dialog_info_body_generator.c:

https://gerrit.asterisk.org/c/asterisk/+/18892/comment/adc8b849_43602a28 
PS4, Line 193: 			ast_copy_pj_str(dlg_remote_uri, ast_sip_pjsip_uri_get_hostname(dlg->local.info->uri), sizeof(dlg_remote_uri));
> Maybe it would be better to bypass this conditional if it's a TEL URI?
Aren't some of these cases impossible currently because we block tel URI for them? For example, here.


File res/res_pjsip_endpoint_identifier_anonymous.c:

https://gerrit.asterisk.org/c/asterisk/+/18892/comment/1fca5979_4076b7c6 
PS4, Line 39: 	ast_copy_pj_str(domain, ast_sip_pjsip_uri_get_hostname(from), domain_size);
> Ack
It won't produce invalid URIs, but the lookup will be "anonymous@". If it's tel URI there's no domain so it shouldn't do the lookup including domain. Same goes for domain alias, shouldn't do that if it's tel URI.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18892
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If5729e6cd583be7acf666373bf9f1b9d653ec29a
Gerrit-Change-Number: 18892
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 14:18:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220907/b8fb7746/attachment.html>