[Asterisk-code-review] func_export: Add EXPORT function (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15893 )

Change subject: func_export: Add EXPORT function
......................................................................


Patch Set 11:

(2 comments)

File funcs/func_export.c:

https://gerrit.asterisk.org/c/asterisk/+/15893/comment/892084ed_fa5ad5a9 
PS10, Line 54: 		<note><para>This is a potentially dangerous function if not used carefully, and the MASTER_CHANNEL and SHARED functions
             : 			should be used instead if possible.</para></note>
> What does "potentially dangerous" mean?
I guess that was mostly a holdover, I'm not convinced that it's dangerous at all. That was referencing a potential locking safety issue but there is none. Removed to avoid confusion.


https://gerrit.asterisk.org/c/asterisk/+/15893/comment/48bb40b5_0a68e1fd 
PS10, Line 109: Arbitrary dialplan set function
> This description isn't very descriptive.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15893
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf
Gerrit-Change-Number: 15893
Gerrit-PatchSet: 11
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:08:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220906/6ffc86b5/attachment-0001.html>