[Asterisk-code-review] res_pjsip_logger: Add method-based logging option. (asterisk[master])

[Alexei Gradinari]

Attention is currently required from: Sean Bright, N A, Joshua Colp.

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18824 )

Change subject: res_pjsip_logger: Add method-based logging option.
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS3: 
> > I still don't want to do string comparisons … so that users without custom methods don't see a per […]
I am also against the custom methods.
1. Performance impact. Even if now "there is no measurable performance impact" (which is not convincing for me), then in future versions of PJSIP there may be.
2. User error. The user may make a mistake in writing the method and the asterisk will not tell about it and the user will think that there are no packets with such a method.
3. Method name is substring of another method name. For example ACK an PRACK.
If I set method ACK I want asterisk to log only ACK packets and not log PRACK packets.

If in some rare cases you need to log custom methods, I think that there should be a separate command for this, for example 'method regex'.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Idd03bd9b466b40e4bca7769437d52ac13a957cf9
Gerrit-Change-Number: 18824
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 14:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220906/410f9aff/attachment-0001.html>