[Asterisk-code-review] res_hiredis: REDIS DeviceState and Dialplan functions (asterisk[master])

[Joshua Colp]

Attention is currently required from: Sean Bright, Alec Davis, N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_hiredis: REDIS DeviceState and Dialplan functions
......................................................................


Patch Set 23: Code-Review-1

(2 comments)

File res/res_hiredis.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c002e107_714edf04 
PS23, Line 880: 	device_state_sub = stasis_subscribe(ast_device_state_topic_all(), device_state_cb, NULL);
Should the device state functionality be optional and enabled in the configuration file?


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/532e15b6_34b0f3d7 
PS23, Line 882: 		return AST_MODULE_LOAD_DECLINE;
This doesn't clean up the configuration in this case.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 23
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Alec Davis <alec at bdt.co.nz>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 12:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220906/19477a41/attachment-0001.html>