[Asterisk-code-review] res_pjsip_logger: Add method-based logging option. (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, Alexei Gradinari.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18824 )

Change subject: res_pjsip_logger: Add method-based logging option.
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS3: 
> My original comment was marked resolved but it has not been. So the same comments as before really: […]
I responded to your comment before, and there was no follow up answer.

I don't see the point in allowing filtering on *anything*. Asterisk only supports the provided methods, so what's the point in allowing somebody to filter on a "FOOBAR" method? Nobody in the real world would do that. In that case, they can enable the full logger, in the 0.0000001% chance that they need to look at methods that Asterisk doesn't even support. I can just see somebody misspelling something like "SUBSRCIBE" and wondering why it's not working, since no error was thrown.

Moreover, the current implementation is very fast. Doing string comparisons will hurt performance.

Also, right now we have tab completion, which I think users will appreciate.

For those reasons, I feel a vector of user provided strings makes less sense.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Idd03bd9b466b40e4bca7769437d52ac13a957cf9
Gerrit-Change-Number: 18824
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 15:08:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220905/f30a03df/attachment.html>