[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[N A]

Attention is currently required from: Sean Bright, Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 13:

(3 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/419fd192_088b101e 
PS8, Line 87: 						<para>Inherit. Group membership will be kept when a channel is transferred.</para>
> This is a work in progress. […]
I see - at the very least, including that explanation in the description would be good.


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/33d2c516_1214a3d6 
PS11, Line 1385: 			ast_str_append(&out, 0, "%s,", ast_channel_name(gi->chan));
> See Line 1394.  This is already taken care of.
Ah, is this new?

In the version I downloaded earlier today, it still has the comma after:

voip*CLI> dialplan eval function GROUP_CHANNEL_LIST(2 at oe)
Return Value: Success (0)
Result: PJSIP/ATAxGrandstream2-00000032,


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/ae1d7af6_0899eb19 
PS11, Line 2473: 
> Isn't it also the case that channel variables can't be deleted either?  They can be set to empty tho […]
Yeah, I guess that's true. I'm not really sure why regular variables work that way either.
I guess it's fine either way.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 13
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Sun, 04 Sep 2022 00:18:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220904/6d736e97/attachment.html>