[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[Mark Murawski]

Attention is currently required from: Sean Bright, N A.

Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 11:

(5 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/074e2c1e_213bb89b 
PS8, Line 87: 						<para>Inherit. Group membership will be kept when a channel is transferred.</para>
> I think more clarification and explanation about the inherit option is needed. […]
This is a work in progress.  Right now, actually no inheritance happens which makes things very very strange when replaces transfers happen and the channel masquerades and now has possibly new group membership.  it would be nice to be able to specify which group variables take priority in this case.


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/02edceca_fe961f00 
PS11, Line 1385: 			ast_str_append(&out, 0, "%s,", ast_channel_name(gi->chan));
> This currently adds a comma after the last channel. […]
See Line 1394.  This is already taken care of.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/98f19446_83e0a919 
PS11, Line 1396: 		  len -= 1; /* rid , only if we didn't go over the buffer limit */
> Indentation is off here
Done


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/58055baa_3d898011 
PS11, Line 2473: 
> Another thought... […]
Isn't it also the case that channel variables can't be deleted either?  They can be set to empty though.

What's the issue here?  Is the wanted functionality to be if the variable is set to nothing then delete it?


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/ed85480b_24c6b342 
PS11, Line 2508:  */
> Doxygen documentation should be moved from the . […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 11
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sat, 03 Sep 2022 23:19:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220903/d38874a2/attachment.html>