[Asterisk-code-review] runInVenv: Remove output redirection. (testsuite[master])

N A asteriskteam at digium.com
Fri Sep 2 06:57:22 CDT 2022


Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/19052 )

Change subject: runInVenv: Remove output redirection.
......................................................................


Patch Set 1:

(1 comment)

File runInVenv.sh:

https://gerrit.asterisk.org/c/testsuite/+/19052/comment/65041c0b_c1a0a935 
PS1, Line 19:     ./setupVenv.sh > /dev/null 2>&1
> what about > /dev/null without the 2>&1 ?
Personally, I would rather see everything, just in case something that should go to stderr goes to stdout, but that might also be reasonable.
I could probably go either way, I'll let someone else weigh in.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/19052
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: I79b32c5374d142688ef4fa26990628aa9c3fcf36
Gerrit-Change-Number: 19052
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Fri, 02 Sep 2022 11:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220902/d1764ab7/attachment.html>


More information about the asterisk-code-review mailing list