[Asterisk-code-review] manager: be more aggressive about purging http sessions. (asterisk[master])

[Joshua Colp]

Attention is currently required from: Jaco Kroon.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18976 )

Change subject: manager: be more aggressive about purging http sessions.
......................................................................


Patch Set 2:

(1 comment)

File include/asterisk/tcptls.h:

https://gerrit.asterisk.org/c/asterisk/+/18976/comment/c878ee77_0a7dbed8 
PS2, Line 141: 	void (*periodic_fn)(struct ast_tcptls_session_args *);/*!< something we may want to run before after select on the accept socket */
> Sure, I can do that (originally did), but this is safer type-wise. […]
My question was because it seemed like a needless change for the sake of a change. Keeping this fix targeted to what it is fixing is what should be done. I don't have any input on the rest of things because I'm not that familiar with this code.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18976
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4117ae25acc9c92bd1d3cfa73d7d334f5c3480c2
Gerrit-Change-Number: 18976
Gerrit-PatchSet: 2
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Thu, 01 Sep 2022 16:14:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Jaco Kroon <jaco at uls.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220901/b658214a/attachment-0001.html>