[Asterisk-code-review] translate.c: Prefer better codecs upon translate ties. (asterisk[master])

George Joseph asteriskteam at digium.com
Mon Oct 31 09:21:06 CDT 2022


Attention is currently required from: N A, Kevin Harwell.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15953 )

Change subject: translate.c: Prefer better codecs upon translate ties.
......................................................................


Patch Set 6:

(1 comment)

Patchset:

PS6: 
> Could there be codecs that might be similar in those properties but one is still inferior from a quality perspective? Then those should not have the same value.

The problem is...  How do you define "inferior" :)
OK maybe a formula isn't the best idea.  How about this...
How about creating an ordered list like chan_iax2.  I think this'd be easier to explain than an arbitrary scale.
Even if we stick with the "quality" score, I'd add the capability to override the score or order defaults in codecs.conf.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15953
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4b7297e1baca7aac14fe4a3c7538e18e2dbe9fd6
Gerrit-Change-Number: 15953
Gerrit-PatchSet: 6
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Mon, 31 Oct 2022 14:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221031/20c32fea/attachment.html>


More information about the asterisk-code-review mailing list